Talk:Luck

Torch luck only applies underground. Try it out, use good torches on the surface and talk to the Wizard. Someone should update the page so people know they’re free to use any torches for surface builds with no negatives.

Ladybug Cage
If we touch a Ladybug Cage just like we touch normal "free" ladybugs, will our luck increase? Pier091 (talk) 13:25, 22 May 2020 (UTC)
 * No; the only thing that impacts ladybug luck is touching a ladybug or gold ladybug NPC. MageKing17 (talk) 18:28, 22 May 2020 (UTC)
 * Too bad. Thanks for answering. Pier091 (talk) 21:13, 23 May 2020 (UTC)

PLACED Torches having no Value and Ladybugs not giving GOOD luck anymore?
Do placed torched not give any torch value point towards luck anymore with 1.4.0.3 update anymore? It appears only holding torches does anything for luck anymore. And later on with testing touching ladybugs I didn't get dialogue about good luck after touching a ladybug with the Wizard, only a bad luck dialogue when I killed one then talked to him. --Dstroyar (talk) 15:08, 21 May 2020 (UTC)

Are you sure? Did he not give you his (Above zero) dialogue? Try touching a golden ladybug and see if he gives you the (Above 0.25) dialogue. Get back to him as quickly as you can. As for Torch Luck, I heard that only negative torch luck was removed, rather than both. 108.217.54.150 19:52, 21 May 2020 (UTC)
 * The luck calculations are exactly the same as before, except torchLuck can't go below 0 and the game scans the area for torches more slowly (it used to scan three rows per frame, now it's just one). In practice, this just means torch luck will take slightly longer to update, but it should happen slightly more often than every second-and-a-half. However, and this is not new behavior, if you're not underground, the game doesn't bother scanning for torches and just uses whatever torch you're holding (if any) to calculate torch luck. MageKing17 (talk) 04:54, 22 May 2020 (UTC)

Does this mean that mismatched biome torches (e.g. ice torches in the jungle) can still cancel out things like the Bone Torch bonus and correct biome torches? 65.185.145.188 06:12, 22 May 2020 (UTC)
 * Yes; the negative score still applies to torch luck, it's just that torch luck itself is capped to a minimum of 0 so that you can't get a luck penalty from it. MageKing17 (talk) 06:19, 22 May 2020 (UTC)

So I tested it a hell of a lot in MP and Ladybugs must be wild, and cannot be released and touched for the positive effects, I tried touching ones I released, and ones others have released with over 20 ladybugs swarming me while spam talking with Wizard and no dice, I was not getting any Luck based dialogue. --Dstroyar (talk) 20:08, 22 May 2020 (UTC)
 * Yes, a player-released Ladybug will not give luck (it also won't give luck if you currently have bad ladybug luck). MageKing17 (talk) 20:14, 22 May 2020 (UTC)
 * The Luck page has been stating that player released ladybugs will give the buff, so I was confused and wasted quite a bit of time testing and trying to make it work lol --Dstroyar (talk) 20:17, 22 May 2020 (UTC)
 * Bah. So much for my 300+ captured ladybugs!  Not to mention the gold one I just caught... right before I need to go to bed irl anyway.  Hmm...  What about statue-spawned ladybugs?  --MentalMouse42 (talk) 02:46, 19 June 2020 (UTC)
 * There is no ladybug statue. MageKing17 (talk) 03:16, 19 June 2020 (UTC)
 * Huh. So there isn't... I could have sworn I saw one on the crafting menu once, but I just checked in-game, and nope. --MentalMouse42 (talk) 10:55, 19 June 2020 (UTC)

Prismatic Lacewing?
Does Luck affect boss item spawns like Prismatic Lacewing, Truffle Worm or Gelatin Crystal? Mathbrush1 (talk) 02:19, 19 May 2020 (UTC)

Actual effect of luck
"If the player's luck is 1.0, there's a 100% chance that the probability is doubled, leading to a final probability of 20%." This is not true. A luck value of 1.0 just means there's a 100% chance of the probability being modified; what the final probability becomes is still random. Using the given example of a 10% chance, assuming a luck value of 1.0, the probability goes from 1 in 10 to 1 in a random value between 5 and 9; this averages out to 7, meaning an average probability of approximately 14.3% (which is most certainly not 20%). MageKing17 (talk) 21:49, 19 May 2020 (UTC)

Actually, this is not how this average works. Your average probability is (1/5 + 1/6 + 1/7 + 1//8 + 1/9)/5 =~ 14.9% 189.4.74.53 07:04, 24 May 2020 (UTC)
 * ...Right. You are correct; obviously, I am a programmer and not a statistician. I'll update my average calculations in the article. MageKing17 (talk) 19:39, 24 May 2020 (UTC)

Luck on Combat
1) When a damage roll is made, is a crit roll also made? 2) Does this apply to received random damage? NoHomeLike192 168 8 1 (talk) 05:29, 20 May 2020 (UTC)
 * It got added to the article: I'm not sure about damage received, but it affects damage dealt by plus (or minus) 5% average (before defense), which I would read as it including the crit roll, because the article doesn't say "base damage". That's more difference than an additional Menacing Prefix would make. So if I understand this correct, players who want to play "optimal" better place torches they might not like, make sure to farm some Garden Gnomes for arenas or farm/fishing spots, spend lots of time fishing for lootbox-y Oysters (which are RNG inside of RNG) and hope you don't murder any Ladybugs by accident - which you might not even notice, because the debuff is hidden... Oh, and don't forget to kill the Guide. What? --46.38.235.14 09:39, 24 May 2020 (UTC)

Ladybug Luck
does capturing ladybugs in a net reduce luck? if it doesnt then you can just touch then catch a ladybug every 3/6 minutes Hipsterhydra (talk) 20:25, 20 May 2020 (UTC)

Campfires...
At least some of the biome torches, and several of the other luck-affecting torches, also have campfires. Do those affect luck, or otherwise react to the biome they're placed in? --MentalMouse42 (talk) 01:19, 21 May 2020 (UTC)
 * Nope! Campfires have absolutely no effect on luck, according to the code. Breathlessblizzard (talk) 01:35, 21 May 2020 (UTC)

Skeleton Merchant inventory is affected by luck?
The main page about Luck says that Luck affects Traveling Merchant and Skeleton Merchant sell inventory, but Skeleton Merchant inventory is not defined when he spawns, and can even change based on conditions after he has spawned, so either his page is missing new items, or there's something wrong. IchijoBR (talk) 06:34, 21 May 2020 (UTC)
 * I wrote that in the early drafting process, on the day we discovered it, and I'm not too sure of its accuracy now. I'll make a change to reflect that, thanks for bringing it to my attention! Breathlessblizzard (talk) 08:19, 21 May 2020 (UTC)

Fishing Affected by luck?
Is fishing affected in any sort of way with luck? BubbleGum~ 23:22, 21 May 2020 (UTC)

It has a chance of affecting fishing level, and opening crates does not care. 73.71.82.80 00:00, 22 May 2020 (UTC)

Overlapping Biomes?
how is torch luck handled in overlapping biomes, eg: Hallowed Snow, Crimson Desert, etc.?
 * The torch luck code just looks at each torch type and its associated biome individually; a Crimson Desert, to this code, is both a Crimson biome and a Desert biome that just so happen to be occupying the same space—and therefore both Corrupt and Desert torches would provide positive score and not negative score. MageKing17 (talk) 19:11, 22 May 2020 (UTC)
 * In that case though, how does a regular torch interact with hybrid biomes? Is the negative score applied twice?
 * No; just like positive score isn't applied twice, a regular torch will just see that it's in a biome it shouldn't be and apply negative score once (however, if one of the hybrid biomes is Snow, that negative score will be 2 instead of 0.5). MageKing17 (talk) 19:41, 24 May 2020 (UTC)

"Touching" ladybugs?
I'm confused, are you supposed to interact with them somehow? How can you "touch" a ladybug if it's 30 blocks away? 68.190.118.39 07:28, 24 May 2020 (UTC)
 * 30 pixels, not 30 blocks. Just run past one so your sprite overlaps it and you'll get the bonus. Breathlessblizzard (talk) 09:04, 24 May 2020 (UTC)

Wizard/Luck
How do I get the Wizard to hint at my luck stat? Is there a video or clip of this occurring?

24.211.141.215 14:30, 24 May 2020 (UTC)


 * Repeatedly talk to him. If you’re not getting quotes, it means your luck is neutral. Breathlessblizzard (talk) 21:19, 24 May 2020 (UTC)

Space
Which torches increase luck for the Space layer/the Floating Islands? --179.43.167.229 17:42, 26 May 2020 (UTC)
 * Presumably Bone Torches (the editor wrote "Sky" in the article instead of "Space" - and "Underworld" instead of "Hell"). --192.160.102.166 17:36, 27 May 2020 (UTC)
 * The usual biome rules apply (e.g. if you create an artificial jungle in the sky, jungle torches will improve torch luck), but given the lack of specialty biomes on floating islands by default, you'll generally only see an effect from Bone Torches. However, by their nature, floating islands aren't underground, so the code to scan for placed torches will be skipped and you'll only see torch luck be affected by the torch you happen to be holding (if you are). MageKing17 (talk) 22:52, 3 June 2020 (UTC)
 * OP here. I have 2 follow up questions:
 * 1) You said the code to scan for placed torches will be skipped - but as far as I can tell from the Torch Luck table, torches "should" work overground as well. (Hallowed Torch is listed for both Hallow and Underground Hallow.) Was this changed with the 1.4.0.5 update? --185.220.101.149 23:45, 5 June 2020 (UTC)
 * 2) The Biome Hair Dye reacts to Space. Up until now I took that as verified information that Space was its own basic biome, similar to Forest/Purity. Since the game told me it was. How sure are you that it isn't? (I'm not insinuating that what you say is wrong - I'm just interested in your source. This whole, undocumented mechanic has just been one big, unesthetic Nightmare for me and I hope they patch it out again, so I can stop paying attention to it.) --185.220.101.149 23:45, 5 June 2020 (UTC)
 * Verified that placed torches only count if player is below the surface and the given biomes on the article are accurate. The best luck increase for the Space layer would be holding the Bone Torch, at half the max value. Luck was not affected in the 1.4.0.5 update. — Dig494talk 05:06, 6 June 2020 (UTC)


 * I didn't say anything about Space not being a biome, though? I just said that floating islands don't have "specialty" biomes (meaning, in this context, a biome with a biome-specific torch, e.g. Jungle, Hallow, Desert...) by default. There are plenty of biomes without biome-specific torches, so Space isn't exactly unique in this regard. Whenever I answer a question about game mechanics, my "source" is the decompiled source code of Terraria itself; I've been decompiling every version as it comes out since 1.3. MageKing17 (talk) 23:29, 13 June 2020 (UTC)
 * I was not picking up on that. Thank you for clarifying. --195.176.3.24 04:22, 15 June 2020 (UTC)
 * * So does Coral (Ocean) Torch give luck when it's placed underwater, but you're outside water but still below 0ft?
 * * Also, only benefit of surface and above torches come if you strictly hold them in your hand? Is the bonus full 0.2, or half? Could this info be added to wiki if true?
 * * How can regular torch reduce -0.4, and the notes say -0.2 in snow as max penalty?
 * If the player is at the Ocean, Coral Torch gives luck regardless of whether or not it's underwater (it doesn't check for whether or not the torch is "dry" unless the Ocean check fails). The bonus aboveground is whatever the torch you may be holding would give; there's no modifier for being held instead of placed. The reduction isn't -0.4 or -0.2; it increases negative score by 2, which translates to a luck modifier of -0.3. When the internal details were replaced with the actual impact on luck, both of those numbers seem to have been converted wrongly; I've corrected them. MageKing17 (talk) 01:00, 16 June 2020 (UTC)
 * Then the bullet point about Coral torch is wrong, since it doesn't need to be submerged, it just needs to a) be in Ocean biome b) be below 0ft. And "Ocean depths" description is a bit misleading, since it's Ocean + below 0ft, not underwater + Ocean. Also, can I please ask that it be stated that torches work above 0ft if held, it's not stated anywhere, just that no torches provide luck above 0ft at all which is also misleading.

The coral note is for when it reduces luck, not increase, so it is correct. Submerged coral torches never reduce luck, only the ones out of water and when you aren't in the ocean depths do, which is what the note says. Ocean depths is the term used by the game. It is the area near the world edges, but above the world gen ocean surface, not below 0ft. Holding a coral torch in the ocean depths and above 0ft will give a luck bonus. It is mentioned that held torches increase luck and it mentioned that placed torches do not increase luck above 0ft. It is incorrect to assume held torches above 0ft are the same as placed torches. It is true ocean "depths" means something different in the code than what we visual, so I will remove the "depths" — Dig494talk 20:16, 16 June 2020 (UTC)

Torch luck radius type?
What kind of radius from a torch does luck activate? Is it a circle, a rhombus-like (90deg rotated square), or a regular square, and from which player block (hitbox 3x2) does it count?
 * The code checks a square 81x81 blocks large centered on the player (in other words, current location ± 40 blocks on each axis). It doesn't check the whole screen at once, instead doing it one row per frame (no doubt as a performance optimization), but standing still for roughly a second and a half should guarantee that every torch in range is affecting your luck. MageKing17 (talk) 23:41, 13 June 2020 (UTC)

Torch God punishes the Underworld? Also, does it correct for holding plain torches?
--MentalMouse42 (talk) 14:17, 19 June 2020 (UTC)
 * First thought: The Torch God places Demon Torches in the Underworld, but apparently Bone Torches would actually offer some benefit.
 * Second thought: Does the Torch God's Favor remove the penalty for carrying a plain torch (that would be converted when you place it?)
 * RE first thought: Bone Torches offer benefit in purity/forest as well (iirc), so clearly they are designed as "extra bonus" and not default
 * RE second thought: The normal torch gets converted both while it is in your hand, and when placed. Hold shift and walk between two biomes, you will see it change.

-- Breathlessblizzard (talk) 14:39, 19 June 2020 (UTC)

Dodging
Does it affect dodging attacks? (e. g. Master Ninja Gear) Abre1510 (talk) 13:11, 5 July 2020 (UTC)


 * It does not. (source: Hurt in Terraria.Player.cs) --Eraloiz (talk) 13:23, 5 July 2020 (UTC)

Turning off torches via wires
Is it possible to use wires to turn off unwanted torches in hybrid biomes to avoid luck penalty? Or the game will count for all placed torches to calculate torch luck, regardless of they are lit or not? BadPiggy1024 (talk) 03:46, 19 February 2021 (UTC)


 * Yes, that is possible. According to Terraria.Player.TryRecalculatingTorchLuck in the 1.4.1.2 source code, only lit Torches are considered for Luck purposes – there is an explicit tile.frameX < 66 check which disabled Torches do not pass. --Rye Greenwood (talk) 15:15, 19 February 2021 (UTC)

Biome keys
does it affect biome keys drop chance? --Blazerun19 (talk) 16:42, 26 May 2021 (UTC)


 * Yes. From the page: "Items affected by luck [...] All rare item drop rates, such as the Ancient Horn or Slimy Saddle (or even Rod of Discord)." (also verified via source code) --Eraloiz (talk) 23:59, 26 May 2021 (UTC)


 * Specifically, the Biome Key drop rule is an instance of ItemDropWithConditionRule, which is itself a subclass of CommonDrop, which uses Player.RollLuck when calculating drop chance. MageKing17 (talk) 19:14, 27 May 2021 (UTC)