Talk:DPS Meter

Bug
The DPS Meter can't take critical hit made by slashing weapons into account, such as Fetid Baghnakhs, Night's edge, Pickaxes and so on. That's probably because in the function ItemCheck of Player.cs, an inproper parameter is passed to the function addDPS. The mistakenly passed parameter is an input of function StrikeNPC, not the output, making the function addDPS always taking a non-critical hit damage.

It seems that the bug meets all the criteria in the Wiki rules, but I am still not sure whether should I include this bug into wiki article.

Heartlessgiraffe (talk) 03:40, 14 September 2019 (UTC)


 * The wiki used to say that the DPS meter simply didn't take Crits into account, based on what the code said about it. Then testing in game revealed the opposite. I'm not sure if a test for Sword weapons has been made, but if this is true and crits don't affect the DPS meter with them, then it should be added. Bame66 (talk) 11:17, 14 September 2019 (UTC)